Rule proposal: force method: "POST" on fetch calls with body

[GauBen]

Description

I sometimes forget to add method: 'POST' to fetch calls

Fail

fetch('http://example.com', { body: '{}' })

Pass

fetch('http://example.com', { method: 'POST', body: '{}' })

Additional Info

No response

[dimaMachina]

Another thing related to fetch - disallow specifying method: 'GET' as it will be set by default

[fisker]

Should not enforce POST, but forbid 'GET'(or omitted)/'HEAD'

[silverwind]

No HTTP method strictly forbids a body, and there are definitely examples of APIs that accept a body on GET, like elasticsearch.

[fisker]

No HTTP method strictly forbids a body

The fetch spec forbid it,

If either init["body"] exists and is non-null or inputBody is non-null, and request’s method is GET or HEAD, then throw a TypeError.

https://fetch.spec.whatwg.org/#request-class

[silverwind]

Interesting, didn't know that. I guess some implemententations may opt to not implement that step, but for a general case, it seems good to have the rule for it then.

I do forsee that the spec may change in the future, similar to how initially a body on DELETE was forbidden by older RFCs, but newer specs now say it MAY have a body 😉. At least OpenAPI reverted their previous policy and they do allow body on GET,HEAD and DELETE.

[fisker]

no-invalid-fetch-options?

[sindresorhus]

no-invalid-fetch-options

👍