-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistent-existence-index-check
add option greater-than and none-zero
#2471
Comments
consistent-existence-index-check
: consistent-existence-index-check
: add option greater-than
and none-zero
Any reason you don't want |
there is no hard reason. i know that it makes no different but it is more precise as value couldn't be below |
consistent-existence-index-check
: add option greater-than
and none-zero
prefer-array-flat
awkward autofix on .concat().concat()
prefer-array-flat
awkward autofix on .concat().concat()
prefer-array-flat
awkward autofix on .concat().concat()
prefer-array-flat
awkward autofix on .concat().concat()
consistent-existence-index-check
: add option greater-than and none-zero
consistent-existence-index-check
: add option greater-than and none-zeroconsistent-existence-index-check
add option greater-than and none-zero
Use Otherwise, someone would write code like this
This makes the code confusing |
I'm going to pass on this. I don't see a strong enough reason to add an option for this. |
Description
I want to have the same option as
explicit-length-check
to choose betweengreater-than
andnone-zero
.none-zero
could stay as default but if changed togreater-than
it should behave as belowFail
Pass
Additional Info
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/explicit-length-check.md#options
The text was updated successfully, but these errors were encountered: