Remove exit handler on exit #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to add a test for this? |
kevva
suggested changes
Feb 20, 2018
test.js
Outdated
| const listener = ee.listeners('exit').pop(); | ||
|
|
||
| await new Promise((resolve, reject) => { | ||
| child.on('error', reject); |
test.js
Outdated
| }); | ||
|
|
||
| const included = ee.listeners('exit').indexOf(listener) !== -1; | ||
| t.false(included); |
There was a problem hiding this comment.
t.false(ee.listeners('exit').includes(listener));
There was a problem hiding this comment.
includes is not supported by Node.js 4.
Putting the expression in t.false produces a long and unhelpful message on test failure:
/Users/rberdeen/work/execa/test.js:524
523:
524: t.false(ee.listeners('exit').indexOf(listener) !== -1);
525: });
Value is not `false`:
true
ee.listeners('exit').indexOf(listener) !== -1
=> true
-1
=> -1
ee.listeners('exit').indexOf(listener)
=> 15
listener
=> Function {}
ee.listeners('exit')
=> [
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
]
ee
=> EventEmitter {
_events: {
afterexit: Function {},
exit: [
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
Function {},
],
},
_eventsCount: 2,
_maxListeners: Infinity,
count: 2,
domain: null,
emitted: {},
infinite: true,
There was a problem hiding this comment.
Oh, right. Array.includes isn't handled by babel (in AVA).
|
Thank you :) |
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always call
removeExitHandler()when the spawned process exits, not only if.then()is called.There was already the
cleanupTimeout()function that was called whenever the spawned process exited, so I repurposed that to clean up everything.Fixes #128