Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect MIME type for Opus files. #677

Closed
2 of 3 tasks
scgehin opened this issue Oct 8, 2024 · 1 comment · Fixed by #682
Closed
2 of 3 tasks

Incorrect MIME type for Opus files. #677

scgehin opened this issue Oct 8, 2024 · 1 comment · Fixed by #682
Labels

Comments

@scgehin
Copy link

scgehin commented Oct 8, 2024

Description

Opus files are given the MIME type "audio/opus", which is not correct. The problem originates from #53, which incorrectly references the RFC for RTP payloads.
The correct MIME type for Opus files is "audio/ogg; codecs=opus", as seen in sections 9 and 10 of this RFC defining the Opus file format.
This issue appears to be the root cause of thelounge/thelounge#4429.

Existing Issue Check

  • I have searched the existing issues and could not find any related to my problem.

ESM (ECMAScript Module) Requirement Acknowledgment

  • My project is an ESM project and my package.json contains the following entry: "type": "module".

File-Type Scope Acknowledgment

  • I understand that file-type detects binary file types and not text or other formats.
@scgehin scgehin added the bug label Oct 8, 2024
@Borewit
Copy link
Collaborator

Borewit commented Oct 11, 2024

I agree @scgehin, do you want to create a PR to improve the MIME type mapping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants