Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expands directories is not working with cwd option #87

Closed
zeakd opened this issue May 21, 2018 · 8 comments
Closed

Expands directories is not working with cwd option #87

zeakd opened this issue May 21, 2018 · 8 comments

Comments

@zeakd
Copy link

zeakd commented May 21, 2018

Hi. with different cwd, expands directories is not working.

└── a/
  ├── b
  └── c/
    ├── d
    └── e
// in directory 'a'

globby('c') // ['c/d', 'c/e']
globby('c', { cwd: process.cwd() }) // ['c/d', 'c/e']
globby('a', { cwd: path.resolve(process.cwd(), '..') }) //  []
globby('a/**/*', { cwd: path.resolve(process.cwd(), '..') }) // ['a/b', 'a/c/d', 'a/c/e']

thanks

@thiagodp
Copy link

Same happening here, version 8.0.1 on Windows

@pvdlg
Copy link
Contributor

pvdlg commented Jul 19, 2018

This is due to kevva/dir-glob#7.
The fix has been done a while ago but it's not released on npm...

@calebboyd
Copy link

@kevva can we bother you for an npm publish?

@sindresorhus sindresorhus changed the title Expands directories is not working with cwd option. Expands directories is not working with cwd option Jan 9, 2019
@sindresorhus
Copy link
Owner

The dir-glob version is published. @pvdlg What needs to be done on our side?

@pvdlg
Copy link
Contributor

pvdlg commented Jan 9, 2019

Yes we have to forward the cwd option (passed to globby) to dir-glob.

@pvdlg
Copy link
Contributor

pvdlg commented Jan 10, 2019

@sindresorhus after looking in more detail we don't have to do anything other than making a new release of globby. The last released version is 8.0.2 which locked to dir-glob dependency to 2.0.0. I don't why...

That has been reversed in commits following 8.0.2, so if we make a new release of globby we should be good.

@sindresorhus
Copy link
Owner

The last released version is 8.0.2 which locked to dir-glob dependency to 2.0.0. I don't why...

See #99 (comment)

@sindresorhus
Copy link
Owner

I have done a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants