Fix encoding with json responseType (#1996)

sindresorhus · Mar 2, 2022 · 0703318 · 0703318
1 parent dbbd317
commit 0703318
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/source/core/response.ts b/source/core/response.ts
@@ -138,7 +138,7 @@ export const parseBody = (response: Response, responseType: ResponseType, parseJ
 		}
 
 		if (responseType === 'json') {
-			return rawBody.length === 0 ? '' : parseJson(rawBody.toString());
+			return rawBody.length === 0 ? '' : parseJson(rawBody.toString(encoding));
 		}
 
 		if (responseType === 'buffer') {

diff --git a/test/encoding.ts b/test/encoding.ts
@@ -0,0 +1,19 @@
+import {Buffer} from 'buffer';
+import test from 'ava';
+import withServer from './helpers/with-server.js';
+
+test('encoding works with json', withServer, async (t, server, got) => {
+	const json = {data: 'é'};
+
+	server.get('/', (_request, response) => {
+		response.set('Content-Type', 'application-json');
+		response.send(Buffer.from(JSON.stringify(json), 'latin1'));
+	});
+
+	const response = await got('', {
+		encoding: 'latin1',
+		responseType: 'json',
+	});
+
+	t.deepEqual(response.body, json);
+});