Fix invalid afterResponse return check

sindresorhus · Aug 12, 2021 · cbc8902 · cbc8902
1 parent 15c30ee
commit cbc8902
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts
@@ -98,7 +98,7 @@ export default function asPromise<T>(firstRequest: Request): CancelableRequest<T
 							throw new RetryError(request);
 						});
 
-						if (!(is.object(response) && is.number(response.statusCode) && response.body)) {
+						if (!(is.object(response) && is.number(response.statusCode) && !is.nullOrUndefined(response.body))) {
 							throw new TypeError('The `afterResponse` hook returned an invalid value');
 						}
 					}

diff --git a/test/hooks.ts b/test/hooks.ts
@@ -1351,3 +1351,19 @@ test('can retry without an agent', withServer, async (t, server, got) => {
 	t.is(response.retryCount, 2);
 	t.is(counter, 1);
 });
+
+test('does not throw on empty body when running afterResponse hooks', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.end();
+	});
+
+	await t.notThrowsAsync(got('', {
+		hooks: {
+			afterResponse: [
+				response => {
+					return response;
+				}
+			]
+		}
+	}));
+});