Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of Node.js 0.10/0.12 #130

Closed
floatdrop opened this issue Nov 15, 2015 · 7 comments
Closed

Drop support of Node.js 0.10/0.12 #130

floatdrop opened this issue Nov 15, 2015 · 7 comments
Milestone

Comments

@floatdrop
Copy link
Contributor

Due to Node LTS schedule - 0.10 version will not be maintained after October 2016 - so we can make 5.x version of got last compatible version with 0.10 and drop support in 6.x and above.

@floatdrop floatdrop added this to the 6.0.0 milestone Nov 15, 2015
@sindresorhus
Copy link
Owner

👍

@floatdrop
Copy link
Contributor Author

@sindresorhus what do you think about 0.12? It's not maintained long after 0.10.

@sindresorhus
Copy link
Owner

I would just drop them both at once. The next one is Node.js 4.2 which brings a lot of improvements and ES2015 goodies.

@floatdrop floatdrop changed the title Drop support of Node.js 0.10 Drop support of Node.js 0.10/0.12 Nov 15, 2015
@arthurvr
Copy link

I'd also drop both. 👍

@sindresorhus
Copy link
Owner

I would also like to drop callback-API support in that version.

@julien-f
Copy link
Contributor

I think it would be good (not necessarily in the near future) to bring the promise and stream APIs closer:

const { stream } = await got.stream('http://example.org')
  • easy to use with ES2015's generators and ES2016's async functions
  • no more complexity to implement retrial on top of streams
  • should be more intuitive to use
  • should be easier to maintain

@floatdrop
Copy link
Contributor Author

@julien-f I don't quite get it. Getting stream is synchronous operation - why should we use await on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants