Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.from is not exists in node 4.5- #242

Closed
tommytroylin opened this issue Nov 4, 2016 · 1 comment
Closed

Buffer.from is not exists in node 4.5- #242

tommytroylin opened this issue Nov 4, 2016 · 1 comment

Comments

@tommytroylin
Copy link
Contributor

tommytroylin commented Nov 4, 2016 •
edited
Loading

Buffer.from(string,'binary') function is first added in node 4.5

on node 4.4.4 it will throw TypeError: binary is not a function

FYI.
Node 4.4.4 Buffer API
Node 4.5.0 Buffer API

Seems like
this commit will break this module on node4.5-
@shinnn
Copy link

shinnn commented Nov 4, 2016

Duplicate of #241

Use 4.5.0 or newer.

@shinnn shinnn closed this as completed Nov 4, 2016
@snyk-bot snyk-bot mentioned this issue Sep 12, 2022
Open
@MaxMood96 MaxMood96 mentioned this issue Jul 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinnn @tommytroylin