General improvements to HTTPS API (Second Edition) #1435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
sindresorhus
requested changes
Jan 13, 2021
| @@ -858,6 +858,20 @@ export interface HTTPSOptions { | |||
| The passphrase to decrypt the `options.https.key` (if different keys have different passphrases refer to `options.https.key` documentation). | |||
| */ | |||
| passphrase?: SecureContextOptions['passphrase']; | |||
|
|
|||
| // TODO add comment | |||
| ciphers?: SecureContextOptions['ciphers']; | |||
There was a problem hiding this comment.
Can we make this support an array of ciphers instead of string with :?
|
|
||
| const createPrivateKey = pify(pem.createPrivateKey); | ||
| const createCSR = pify(pem.createCSR); | ||
| const createCertificate = pify(pem.createCertificate); | ||
| const createPkcs12 = pify(pem.createPkcs12); | ||
|
|
||
| test('https request without ca', withHttpsServer(), async (t, server, got) => { | ||
| const ciphers = tls.getCiphers().map(cipher => cipher.toUpperCase()); |
There was a problem hiding this comment.
Would be more readable if you used destructuring here.
|
Can you fix the merge conflicts? |
szmarczak
requested changes
Apr 11, 2021
| @@ -858,6 +858,20 @@ export interface HTTPSOptions { | |||
| The passphrase to decrypt the `options.https.key` (if different keys have different passphrases refer to `options.https.key` documentation). | |||
| */ | |||
| passphrase?: SecureContextOptions['passphrase']; | |||
|
|
|||
| // TODO add comment | |||
Yes, I think it's better to close this PR and open a new one, but recently I haven't been able to work on this repo. |
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the previous "General improvements to HTTPS API" (#1255) this PR is going to add the remaining HTTPS options described in #1306 (or, at least, most of them).
This PR is still WIP.
Implemented options to date (completed on "code, test and docs"):
ciphers: code, testhonorCipherOrder: code, testminVersion: code, testmaxVersion: code, testChecklist
(Partially) Fixes #1306
Fixes #1299