No way to set timeout for .text() / .json()?

[Mercencium]

I've sent three requests via await ky.get(url, {timeout: 1_500}).json()

The first two requests are cancelled on timeout as expected.

But the third request has connected within 1.5s and started downloading the response body, exceeding the configured timeout:

Is there a way to set timeout for reading the body?

Without it, & .text() & .json() promises have the potential to hang indefinitely - that's exactly what happened to me today with vanilla fetch API.

[sholladay]

I'm pretty sure the AbortController is supposed to cancel the download if one is in progress. This would be good to add to our test suite. Do you have some reproducible code?

[Mercencium]

Here's the code:

import ky from "ky";

const URL = "https://jsonplaceholder.typicode.com/comments";
const TIMEOUT = 800;

async function test() {
  function elapsed() {
    return Math.round(new Date() - started_at);
  }
  const started_at = new Date();

  let resp;
  try {
    resp = await ky.get(URL, { timeout: TIMEOUT });
  } catch (e) {
    console.error(`Fetch error in ${elapsed()}ms`);
    return;
  }
  console.info(`Connection started in ${elapsed()}ms`);
  let data;
  try {
    data = await resp.json();
  } catch (e) {
    console.error(`JSON error in ${elapsed()}ms`);
    return;
  }

  const total = elapsed();
  const warning = total > TIMEOUT ? "⚠️" : "";
  console.info(`Done in ${total}ms ${warning}`);

  return data;
}

await test();
console.log();
await test();

I ran it with node.js and the output was:

Fetch error in 812ms

Connection started in 618ms
Done in 2720ms ⚠️ 

The first request got timed out at 800ms as expected,
but the second one connected before timeout (in 618ms), and then read the json body in about 2 seconds (2720 - 618).

Note that you need to throttle your connection somehow (Or lower the timeout significantly)
For me It works regardless because my internet sucks 😅

[Mercencium]

Just discovered that replacing timeout: TIMEOUT option with signal: AbortSignal.timeout(TIMEOUT) fixes this.

Now it can throw an error on .json() call when it timeouts:

Fetch error in 809ms

Connection started in 511ms
JSON error in 803ms