-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: configure Pure colors via prompt init #306
Comments
Does ZSH have a nicer way to do options? I don't like positional arguments like this, and environment variables are global. |
Maybe something like |
We could definitely use What you're proposing would work, but it might be good to put them in a subcategory: zstyle :prompt:pure:color duration yellow
zstyle :prompt:pure:color error red
zstyle :prompt:pure:color branch 242
zstyle :prompt:pure:color unpushed cyan
zstyle :prompt:pure:color unpulled cyan
zstyle :prompt:pure:color root white
zstyle :prompt:pure:color success green
zstyle :prompt:pure:color user 242 This could even allow different theming based on if you're in a git directory or not, say we started supporting mercurial:
Not sure how this would look in practice, but it should be possible. Not sure if there's value in it. One issue with this approach is that it doesn't really decrease the amount of configuration, but perhaps allows us to keep "colors" to simply one section? |
👍 |
@mafredri So it seems we agree on the solution. Should we label this as "help wanted" (PR welcome)? |
@IssueHunt has funded $80.00 to this issue.
|
@sindresorhus has rewarded $72.00 to @bricewge. See it on IssueHunt
|
We receive a lot of requests for changing colors in Pure, one prevalent reason is color blindness and hard-to-distinguish colors. Many of the themes that ship with Zsh allow color schemeability during prompt init and I believe we could utilize this in Pure as well.
Example:
These could maybe even be just
color1
,color2
, etc.Benefits:
Downsides:
red
, or whatever...1 Unofficially the internals are probably such that the user could change them, but this would of course be unsupported and could break at any time.
As a bonus, we could implement
prompt_pure_help
to provide a help dialogue (on how to use/modify pure) for the user. This can be displayed withprompt -h pure
.References:
// ping @sindresorhus
IssueHunt Summary
[
<
i
m
g
s
r
c
'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
3
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
5
5
2
5
6
4
6
?
v
4
'
a
l
t
'
b
r
i
c
e
w
g
e
'
w
i
d
t
h
2
4
h
e
i
g
h
t
2
4
b
r
i
c
e
w
g
e
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
b
r
i
c
e
w
g
e
)
h
a
s
b
e
e
n
r
e
w
a
r
d
e
d
.
Backers (Total: $80.00)
Submitted pull Requests
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: