Add bigint[] to log-based type lookup #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
https://stitchdata.atlassian.net/browse/SUP-895
For data types of
int8[]
that get reported by postgres asbigint[]
into the metadata'ssql-datatype
field, log-based was incorrectly typing them as String during the data type conversion lookup. The schema still has integer for these columns, it's just that the records don't match once emitted.This PR fixes that by adding a case for
bigint[]
and preventing the fallback totext[]
.QA steps
Risks
Low, this is an additive change.
Rollback steps