fix(demos): remove declaration of external dependencies

feature-hub · Sep 20, 2022 · 0f16746 · 0f16746
1 parent c83ec51
commit 0f16746
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 28 deletions.
diff --git a/packages/demos/src/advanced-routing/hello-world-feature-app.tsx b/packages/demos/src/advanced-routing/hello-world-feature-app.tsx
@@ -35,9 +35,6 @@ const featureAppDefinition: FeatureAppDefinition<
     featureServices: {
       'test:hello-world-service': '^1.0.0',
     },
-    externals: {
-      react: '^16.7.0',
-    },
   },
 
   create: ({featureServices}) => ({

diff --git a/packages/demos/src/advanced-routing/input-feature-app.tsx b/packages/demos/src/advanced-routing/input-feature-app.tsx
@@ -39,9 +39,6 @@ const featureAppDefinition: FeatureAppDefinition<
     featureServices: {
       'test:navigation-service': '^1.0.0',
     },
-    externals: {
-      react: '^16.7.0',
-    },
   },
 
   create: ({featureServices}) => {

diff --git a/packages/demos/src/custom-logging/feature-app.tsx b/packages/demos/src/custom-logging/feature-app.tsx
@@ -14,7 +14,6 @@ const featureAppDefinition: FeatureAppDefinition<
   Dependencies
 > = {
   dependencies: {
-    externals: {react: '^16.7.0'},
     featureServices: {'s2:logger': '^1.0.0'},
   },
 

diff --git a/packages/demos/src/feature-app-in-feature-app/feature-app-inner.tsx b/packages/demos/src/feature-app-in-feature-app/feature-app-inner.tsx
@@ -4,13 +4,6 @@ import {ReactFeatureApp} from '@feature-hub/react';
 import * as React from 'react';
 
 const featureAppDefinition: FeatureAppDefinition<ReactFeatureApp> = {
-  dependencies: {
-    externals: {
-      react: '^16.7.0',
-      '@feature-hub/react': '^2.0.0',
-    },
-  },
-
   create: ({done}) => ({
     render: () => (
       <>

diff --git a/packages/demos/src/feature-app-in-feature-app/feature-app-outer.tsx b/packages/demos/src/feature-app-in-feature-app/feature-app-outer.tsx
@@ -27,13 +27,6 @@ function OuterFeatureApp({featureAppId}: OuterFeatureAppProps): JSX.Element {
 }
 
 const featureAppDefinition: FeatureAppDefinition<ReactFeatureApp> = {
-  dependencies: {
-    externals: {
-      react: '^16.7.0',
-      '@feature-hub/react': '^2.0.0',
-    },
-  },
-
   create: ({featureAppId}) => ({
     render: () => <OuterFeatureApp featureAppId={featureAppId} />,
   }),

diff --git a/packages/demos/src/module-loader-amd/feature-app.tsx b/packages/demos/src/module-loader-amd/feature-app.tsx
@@ -4,10 +4,6 @@ import {ReactFeatureApp} from '@feature-hub/react';
 import * as React from 'react';
 
 const featureAppDefinition: FeatureAppDefinition<ReactFeatureApp> = {
-  dependencies: {
-    externals: {react: '^16.7.0'},
-  },
-
   create: () => ({
     render: () => (
       <Card style={{margin: '20px'}}>

diff --git a/packages/demos/src/server-side-rendering/feature-app.tsx b/packages/demos/src/server-side-rendering/feature-app.tsx
@@ -19,7 +19,6 @@ const featureAppDefinition: FeatureAppDefinition<
   Dependencies
 > = {
   dependencies: {
-    externals: {react: '^16.7.0'},
     featureServices: {'s2:serialized-state-manager': '^1.0.0'},
   },
 

diff --git a/packages/demos/src/todomvc/footer/index.tsx b/packages/demos/src/todomvc/footer/index.tsx
@@ -13,7 +13,6 @@ const featureAppDefinition: FeatureAppDefinition<
   FooterFeatureServices
 > = {
   dependencies: {
-    externals: {react: '^16.7.0'},
     featureServices: {'test:todomvc-todo-manager': '^1.0.0'},
   },
 

diff --git a/packages/demos/src/todomvc/main/index.tsx b/packages/demos/src/todomvc/main/index.tsx
@@ -13,7 +13,6 @@ const featureAppDefinition: FeatureAppDefinition<
   MainFeatureServices
 > = {
   dependencies: {
-    externals: {react: '^16.7.0'},
     featureServices: {'test:todomvc-todo-manager': '^1.0.0'},
   },