feat(react): the loader will not try to load an empty src (#186)

Closes #150
feature-hub · Dec 14, 2018 · 236c487 · 236c487
1 parent f04693c
commit 236c487
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/react/src/__tests__/feature-app-loader.test.tsx b/packages/react/src/__tests__/feature-app-loader.test.tsx
@@ -43,8 +43,16 @@ describe('FeatureAppLoader', () => {
     spyConsoleError.mockRestore();
   });
 
+  it('throws an error if no src is provided', () => {
+    expect(() =>
+      shallow(<FeatureAppLoader manager={mockManager} src="" />)
+    ).toThrowError(new Error('No src provided.'));
+  });
+
   it('initially renders nothing', () => {
-    const wrapper = shallow(<FeatureAppLoader manager={mockManager} src="" />);
+    const wrapper = shallow(
+      <FeatureAppLoader manager={mockManager} src="/test.js" />
+    );
 
     expect(wrapper.isEmptyRender()).toBe(true);
   });

diff --git a/packages/react/src/feature-app-loader.tsx b/packages/react/src/feature-app-loader.tsx
@@ -43,6 +43,10 @@ export class FeatureAppLoader extends React.PureComponent<
     const src = inBrowser ? browserSrc : nodeSrc;
 
     if (!src) {
+      if (inBrowser) {
+        throw new Error('No src provided.');
+      }
+
       return;
     }