feat(react): improve log message if ID specifier is missing (#204)

feature-hub · Dec 20, 2018 · cc8be3d · cc8be3d
1 parent e380857
commit cc8be3d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/packages/react/src/__tests__/feature-app-loader.test.tsx b/packages/react/src/__tests__/feature-app-loader.test.tsx
@@ -271,11 +271,7 @@ describe('FeatureAppLoader', () => {
     describe('when unmounted before loading has finished', () => {
       it('logs an error', async () => {
         const wrapper = shallow(
-          <FeatureAppLoader
-            manager={mockManager}
-            src="/test.js"
-            idSpecifier="testIdSpecifier"
-          />
+          <FeatureAppLoader manager={mockManager} src="/test.js" />
         );
 
         wrapper.unmount();
@@ -290,7 +286,7 @@ describe('FeatureAppLoader', () => {
 
         expect(spyConsoleError.mock.calls).toEqual([
           [
-            'The feature app for the src "/test.js" and the ID specifier "testIdSpecifier" could not be rendered.',
+            'The feature app for the src "/test.js" could not be rendered.',
             mockError
           ]
         ]);

diff --git a/packages/react/src/feature-app-loader.tsx b/packages/react/src/feature-app-loader.tsx
@@ -149,11 +149,15 @@ export class FeatureAppLoader extends React.PureComponent<
     const src = inBrowser ? browserSrc : nodeSrc;
 
     console.error(
-      `The feature app for the src ${JSON.stringify(
-        src
-      )} and the ID specifier ${JSON.stringify(
-        idSpecifier
-      )} could not be rendered.`,
+      idSpecifier
+        ? `The feature app for the src ${JSON.stringify(
+            src
+          )} and the ID specifier ${JSON.stringify(
+            idSpecifier
+          )} could not be rendered.`
+        : `The feature app for the src ${JSON.stringify(
+            src
+          )} could not be rendered.`,
       error
     );
   }