Skip to content

Commit

Permalink
fix(react): deprecate FeatureHubContextValue interface (#411)
Browse files Browse the repository at this point in the history
  • Loading branch information
unstubbable authored Mar 11, 2019
1 parent 470acd3 commit fc13a16
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/demos/src/server-side-rendering/integrator.node.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {createFeatureHub} from '@feature-hub/core';
import {loadCommonJsModule} from '@feature-hub/module-loader-commonjs';
import {
FeatureHubContextProvider,
FeatureHubContextValue
FeatureHubContextProviderValue
} from '@feature-hub/react';
import {
SerializedStateManagerV1,
Expand Down Expand Up @@ -43,7 +43,7 @@ export default async function renderApp({

const urlsForHydration = new Set<string>();

const featureHubContextValue: FeatureHubContextValue = {
const featureHubContextValue: FeatureHubContextProviderValue = {
featureAppManager,
asyncSsrManager,

Expand Down
4 changes: 4 additions & 0 deletions packages/react/src/feature-hub-context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ export interface FeatureHubContextProviderValue {
addUrlForHydration?(url: string): void;
}

/**
* @deprecated Use {@link FeatureHubContextProviderValue} or
* {@link FeatureHubContextConsumerValue} instead.
*/
export type FeatureHubContextValue = FeatureHubContextProviderValue;

export type FeatureHubContextConsumerValue = SomeRequired<
Expand Down

0 comments on commit fc13a16

Please sign in to comment.