Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-renderer): move and adapt old SSR code #135

Merged
merged 17 commits into from
Jan 8, 2019

Conversation

unstubbable
Copy link
Member

@unstubbable unstubbable commented Dec 4, 2018

This is the first iteration of the server renderer feature service.

Things to consider and/or fix:

  • Can we avoid using setTimeout in unit tests, and/or use jest.useFakeTimers()?
  • Move rerenderWait to config, remove default in ServerRenderer constructor.
  • Add a test scenario for when a feature app module fails to load.
  • Throw an error when renderUntilCompleted is called more than once.

Tasks for follow-up PRs:

packages/server-renderer/src/index.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/index.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/index.ts Outdated Show resolved Hide resolved
@unstubbable unstubbable force-pushed the server-renderer branch 2 times, most recently from c2ad98d to d0cb610 Compare December 7, 2018 09:51
@unstubbable unstubbable changed the title WIP: feat(server-renderer): move and adapt old SSR code feat(server-renderer): move and adapt old SSR code Dec 7, 2018
packages/server-renderer/src/index.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/__tests__/index.test.ts Outdated Show resolved Hide resolved
fahrradflucht
fahrradflucht previously approved these changes Jan 7, 2019
@unstubbable unstubbable dismissed clebert’s stale review January 8, 2019 08:23

every comment is resolved, and fahrradflucht approved

@unstubbable unstubbable removed the request for review from clebert January 8, 2019 08:23
@unstubbable unstubbable merged commit b33f744 into master Jan 8, 2019
@unstubbable unstubbable deleted the server-renderer branch January 8, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants