-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server-renderer): move and adapt old SSR code #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
commented
Dec 4, 2018
unstubbable
force-pushed
the
server-renderer
branch
2 times, most recently
from
December 7, 2018 09:51
c2ad98d
to
d0cb610
Compare
unstubbable
changed the title
WIP: feat(server-renderer): move and adapt old SSR code
feat(server-renderer): move and adapt old SSR code
Dec 7, 2018
unstubbable
force-pushed
the
server-renderer
branch
from
December 18, 2018 10:17
a812364
to
5b0049e
Compare
unstubbable
force-pushed
the
server-renderer
branch
from
January 7, 2019 09:22
5b0049e
to
13de1c7
Compare
clebert
requested changes
Jan 7, 2019
unstubbable
force-pushed
the
server-renderer
branch
from
January 7, 2019 10:38
13de1c7
to
e6be9fe
Compare
clebert
previously requested changes
Jan 7, 2019
This allows us to handle the state transitions internally.
It can be replaced by combining register and rererender, while handling the promise outside of the server renderer.
unstubbable
force-pushed
the
server-renderer
branch
from
January 7, 2019 12:42
c91141a
to
4be50fa
Compare
fahrradflucht
previously approved these changes
Jan 7, 2019
unstubbable
force-pushed
the
server-renderer
branch
from
January 8, 2019 08:15
50e8be1
to
9ce3e84
Compare
fahrradflucht
approved these changes
Jan 8, 2019
unstubbable
dismissed
clebert’s stale review
January 8, 2019 08:23
every comment is resolved, and fahrradflucht approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration of the server renderer feature service.
Things to consider and/or fix:
setTimeout
in unit tests, and/or usejest.useFakeTimers()
?rerenderWait
to config, remove default inServerRenderer
constructor.renderUntilCompleted
is called more than once.Tasks for follow-up PRs:
rerenderWait
(and debounce functionality) with fake timers. SSR: test rerenderWait (and debounce functionality) with fake timers #153async-ssr-manager
. SSR: Renameserver-renderer
package toasync-ssr-manager
#154FeatureAppLoader
. SSR: Integrate Async SSR Manager intoFeatureAppLoader
#157Handle timeouts per loading feature app module.