Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History Service: Missing URLSearchParams as global on node 8 #298

Closed
fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #301
Closed

History Service: Missing URLSearchParams as global on node 8 #298

fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #301
Labels
bug Something isn't working
Milestone
1.0

Comments

@fahrradflucht
Copy link
Member

The history service currently accesses the URLSearchParams directly which isn't available on node 8. The unit tests didn't catch this due to use setting it in the test setup script - this should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

fix(all): on Node 8 require URLSearchParams from url module feature-hub/feature-hub
1 participant
@fahrradflucht