feat(demos): enable SSR for "Feature App in Feature App" demo and fix externals config #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
changed the title
unstubbable
force-pushed
the
fa-in-fa-ssr
branch
from
16db180
to
bb55073
Compare
unstubbable
changed the title
clebert
requested changes
Feb 4, 2019
|
|
||
| // In a real-world integrator, instead of preloading a Feature App manually | ||
| // before rendering, the Async SSR Manager would be used to handle the | ||
| // asynchronous server-side rendering (see "server-side-rendering" demo). |
There was a problem hiding this comment.
In the demos README it is spelled: "Server-Side Rendering" demo
| @@ -15,6 +15,9 @@ export default async function renderApp({ | |||
| moduleLoader: loadCommonJsModule | |||
| }); | |||
|
|
|||
| // In a real-world integrator, instead of preloading a Feature App manually | |||
| // before rendering, the Async SSR Manager would be used to handle the | |||
| // asynchronous server-side rendering (see "server-side-rendering" demo). | |||
unstubbable
force-pushed
the
fa-in-fa-ssr
branch
from
bb55073
to
7476df8
Compare
clebert
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.