fix(all): do not destroy Feature App when it is rendered multiple times #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #505 BREAKING CHANGE: `FeatureAppManager#getFeatureAppScope` has been replaced by `FeatureAppManager#createFeatureAppScope`, since now a new `FeatureAppScope` is created for every call. When a Feature App is unmounted, the `release` method (previously called `destroy`) must be called. Only when all scopes for a Feature App ID have been released, the Feature App instance is destroyed.
unstubbable
force-pushed
the
feature-app-scope-destroy-bug
branch
from
4fd80da
to
a51cfdd
Compare
clebert
previously approved these changes
Jun 14, 2019
unstubbable
force-pushed
the
feature-app-scope-destroy-bug
branch
from
4dd5a9c
to
a3a7b4f
Compare
clebert
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #505
BREAKING CHANGE:
FeatureAppManager#getFeatureAppScopehas been replaced byFeatureAppManager#createFeatureAppScope, since now a newFeatureAppScopeis created for every call. When a Feature App is unmounted, thereleasemethod (previously calleddestroy) must be called. Only when all scopes for a Feature App ID have been released, the Feature App instance is destroyed.