Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(history-service): introduce v3 of the history service #716

Merged
merged 12 commits into from
Sep 20, 2022

Conversation

unstubbable
Copy link
Member

@unstubbable unstubbable commented Sep 6, 2022

Version 3 of the history service provides a history that is compatible with v5 of the history package and therefore can also be used together with v6 of React Router.

BREAKING CHANGE: Version 5 of the history package is now required as peer dependency. Some types of the root location transformer have been slightly changed, and the deprecated primaryConsumerId has been removed (replaced by primaryConsumerHistoryKey).

@unstubbable
Copy link
Member Author

/prerelease

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Prereleased with npm dist-tag "history-v5"

@unstubbable
Copy link
Member Author

/prerelease

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Prereleased with npm dist-tag "history-v5"

@unstubbable unstubbable force-pushed the history-v5 branch 3 times, most recently from 81a4258 to eac581b Compare September 9, 2022 09:21
@unstubbable unstubbable changed the title feat(history-service): use history v5 feat(history-service): introduce v3 of the history service Sep 9, 2022
@unstubbable
Copy link
Member Author

/prerelease

@unstubbable
Copy link
Member Author

/deploy

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Prereleased with npm dist-tag "history-v5"

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Deployed to https://eac581b3.feature-hub.io

@unstubbable unstubbable marked this pull request as ready for review September 9, 2022 09:38
@unstubbable
Copy link
Member Author

/prerelease

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Prereleased with npm dist-tag "history-v5"

@unstubbable
Copy link
Member Author

/prerelease

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Prereleased with npm dist-tag "history-v5"

@unstubbable
Copy link
Member Author

/deploy

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Deployed to https://f376f3a2.feature-hub.io

clebert
clebert previously approved these changes Sep 14, 2022
BREAKING CHANGE: Version 5 of the `history` package is now required as
peer dependency. Some types of the root location transformer have been
slightly changed, and the deprecated `primaryConsumerId` has been
removed (replaced by `primaryConsumerHistoryKey`).
@clebert clebert self-requested a review September 20, 2022 08:47
@unstubbable unstubbable merged commit 7c7c386 into master Sep 20, 2022
@unstubbable unstubbable deleted the history-v5 branch September 20, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants