Add WithContext #919
Merged
Add WithContext #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
approved these changes
Mar 11, 2019
|
Context are pretty useful indeed. |
This was referenced Oct 11, 2019
This was referenced Oct 30, 2019
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
Add WithContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WithContext(ctx context.Context)method, and aContextproperty, onEntry. Contexts aren't that useful for the logging itself, but it can be very useful for hooks you may have configured.Example: You have Bugsnag configured, which store request metadata in the context, and you want to notify Bugsnag on any error-level logs. Without passing along the context through the log entry, the Bugsnag report will lack a lot of interesting detail.