-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor UX Regression #857
Comments
Which OS and browser are you using? Edit: Can sort of reproduce this on macOS where the dropdown now uses a light background instead of a dark one. It seems the issue is that the background color of the select is a semi transparent white, which causes the browser / OS to use a light background for the overlay. Using a dark color without transparency fixes it. The transparent white was an easy solution to make the select look distinct from the background, regardless of the background color. Ideally there would be a way to tell the browser to use a dark overlay, otherwise this might require defining different select background colors for each usage scenario. |
Windows 11 Pro with Chrome 129. I don't use the Light, but I switch just test and is fine but the White version now is blow white everywhere: For all other UX changes only get better! PS: Dark on Android 14 works just fine. |
https://github.com/sissbruecker/linkding/blob/master/bookmarks/styles/theme/forms.css#L144 .form-select option {
background-color: var(--body-color) !important;
} This did the trick: |
Yeah, that won't work on macOS or iOS unfortunately, browsers there always use a native dropdown menu that uses either a light or dark theme. But it's a workaround for other systems for now. |
Should be fixed now. On Windows, at least for Chrome and Edge, I had to set explicitly set the background on the options as you suggested. Apart from that there's a |
After the migration to use pure CSS and the changes I noted a minor regression in combox:
This happens on dark theme.
The text was updated successfully, but these errors were encountered: