Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility/aria-labels on MenuSelect components #175

Open
sjdemartini opened this issue Oct 30, 2023 · 0 comments
Open

Improve accessibility/aria-labels on MenuSelect components #175

sjdemartini opened this issue Oct 30, 2023 · 0 comments

Comments

@sjdemartini
Copy link
Owner

sjdemartini commented Oct 30, 2023

would it be possible to add a aria-label to the inputs like font family and font size? There currently is one, but it's not on the input so there is a missing label error from an accessibility standpoint

Originally posted by @sgober in #174 (comment)

Based on https://mui.com/material-ui/react-select/#accessibility, it seems we perhaps shouldn't be providing an aria-label the way we are, though it's not entirely clear to me what the right pattern is when you don't have a separate label element. (https://mui.com/material-ui/react-select/#accessibility, https://mui.com/material-ui/react-text-field/#accessibility)

For what it's worth, the Select's input itself has aria-hidden="true", so I don't think it needs the aria-label, but there may be a better way to handle a11y with these components.


Please leave a comment and/or feel free to make a PR if you have suggestions on the "right way" to improve this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant