Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk function doing one day more #77

Open
alexsnsk opened this issue Nov 4, 2015 · 8 comments
Open

Walk function doing one day more #77

alexsnsk opened this issue Nov 4, 2015 · 8 comments

Comments

@alexsnsk
Copy link

alexsnsk commented Nov 4, 2015

Hello,

I'm using the WALK = TRUE function to avoid sampled data and it is doing a day more than the end date.
Call:
getData(ID,
batch = TRUE,
walk = TRUE,
"2015-09-01",
"2015-10-31"
metrics = "ga:sessions,ga:bounces,ga:sessionDuration,ga:pageviews",
dimensions = "ga:month",
sort ="ga:month")

but it's running also for 2015-11-01.

Any tips?

@mattpolicastro
Copy link
Contributor

This might be a crackpot theory, but which time zone is your GA account configured to use?

@EricGoldsmith
Copy link
Contributor

This may be the bug I ran into, and fixed in my local fork. I'm afraid I've not gotten around to issuing a pull request for it.

@alexsnsk
Copy link
Author

alexsnsk commented Nov 5, 2015

I think the problem is not in the timezone. I've been running the exact code to extract monthly reports whithout a problem.

Seems like @EricGoldsmith is in the right direction. Yesterday testing I saw that the walks.max was giving some inacurate date diffs. ( 2015-09-01 to 2015-10-31 = 62 days :O)

@EricGoldsmith
Copy link
Contributor

I submitted a PR for this update: #81

@EricGoldsmith
Copy link
Contributor

@alexsnsk, @mattpolicastro, @skardhamar, thoughts on merging this PR?

@alexsnsk
Copy link
Author

I think it is a must!! Nice work there!

2016-02-29 15:21 GMT+01:00 Eric Goldsmith notifications@github.com:

@alexsnsk https://github.com/alexsnsk, @mattpolicastro
https://github.com/mattpolicastro, @skardhamar
https://github.com/skardhamar, thoughts on merging this PR?


Reply to this email directly or view it on GitHub
#77 (comment).

@mattpolicastro
Copy link
Contributor

👍

@EricGoldsmith
Copy link
Contributor

@alexsnsk, can you confirm that this is now fixed, and then close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants