Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Support Unicode international characters #151

Merged
merged 15 commits into from
Feb 15, 2017
Merged

Support Unicode international characters #151

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b4566ba
Support Unicode international characters
WesTyler Feb 7, 2017
7c7901f
Disable linting for rewire "let" workaround
WesTyler Feb 7, 2017
0ab6884
Add inline comment for eslint ignore on prefer-const rule
Feb 7, 2017
3487199
Expand test coverage of Unicode cases
WesTyler Feb 7, 2017
fbd9f1c
Utilize array.fill; do not pin dependency at the patch level
WesTyler Feb 7, 2017
86c3194
Specify C0 and C1 charCode ranges to allow unicode
WesTyler Feb 8, 2017
79e2261
Replace rewire with proxyquire
WesTyler Feb 8, 2017
24f78ef
Remove "let" and eslint override introduced by rewire useage
WesTyler Feb 8, 2017
996a71e
Add normalization to email addresses
WesTyler Feb 9, 2017
e836377
Monkey-patch V8 NUL normalize bug for Node 4.x
WesTyler Feb 10, 2017
10bb502
Utilize indexOf instead of regex match for speed
WesTyler Feb 10, 2017
38039b8
Add unicode length tests
skeggse Feb 11, 2017
599a245
Check for surrogate pairs in token iteration
WesTyler Feb 11, 2017
1fdcf9e
Check Buffer.byteLength instead of string.length
WesTyler Feb 11, 2017
1d20f07
Deprecate internals.checkSurrogatePair
WesTyler Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,19 @@ internals.regex = {
ipV6: /^[a-fA-F\d]{0,4}$/
};

// $lab:coverage:off$
internals.nulNormalize = function (email) {

let emailPieces = email.split('\u0000');
emailPieces = emailPieces.map((string) => {

return string.normalize('NFC');
});

return emailPieces.join('\u0000');
};
// $lab:coverage:on$


internals.checkIpV6 = function (items) {

Expand Down Expand Up @@ -1413,5 +1426,12 @@ exports.diagnoses = internals.validate.diagnoses = (function () {

exports.normalize = internals.normalize = function (email) {

// $lab:coverage:off$
if (process.version[1] === '4' && email.match(/\0/g)) {
Copy link

@lamchakchan lamchakchan Feb 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend replacing regex with a simple indexOf for performance reasons.

if (process.version[1] === '4' && email.indexOf('\u0000') === 0) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it. Just haven't pushed up yet :)
Also, using email.indexOf('/u0000') >= 0 because the NUL is not necessarily at the beginning

return internals.nulNormalize(email);
}
// $lab:coverage:on$


return email.normalize('NFC');
};