Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip should not be enabled by default #83

Open
faddat opened this issue Dec 8, 2022 · 0 comments
Open

Skip should not be enabled by default #83

faddat opened this issue Dec 8, 2022 · 0 comments

Comments

@faddat
Copy link

faddat commented Dec 8, 2022

In order for this set of tools to drive positive changes in developing the tendermint software, Skip should be disabled by default, so that logs aren't flooded like this:

6:50PM ERR Looking to reconnect after StopPeerForError, peer is  module=p2p
6:50PM INF Connection is closed @ recvRoutine (likely by the other side) conn={"Logger":{}} module=p2p peer={"id":"8891c131543ccbbbe86fc7f01baa892bdb4b9c60","ip":"65.21.238.147","port":64656}
6:50PM INF service stop impl={"Logger":{}} module=p2p msg={} peer={"id":"8891c131543ccbbbe86fc7f01baa892bdb4b9c60","ip":"65.21.238.147","port":64656}
6:50PM INF service stop impl={"Data":{},"Logger":{}} module=p2p msg={} peer={"id":"8891c131543ccbbbe86fc7f01baa892bdb4b9c60","ip":"65.21.238.147","port":64656}
6:50PM ERR Looking to reconnect after StopPeerForError, peer is  module=p2p
6:50PM INF Connection is closed @ recvRoutine (likely by the other side) conn={"Logger":{}} module=p2p peer={"id":"aff7a94febed844f1024be41d9d527ebec2c0bba","ip":"85.214.171.156","port":36656}
6:50PM INF service stop impl={"Logger":{}} module=p2p msg={} peer={"id":"aff7a94febed844f1024be41d9d527ebec2c0bba","ip":"85.214.171.156","port":36656}
6:50PM INF service stop impl={"Data":{},"Logger":{}} module=p2p msg={} peer={"id":"aff7a94febed844f1024be41d9d527ebec2c0bba","ip":"85.214.171.156","port":36656}
6:50PM ERR Looking to reconnect after StopPeerForError, peer is  module=p2p

Suggest a bool in config.toml whose default setting is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant