Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blog Post about improvement in SkoHub Pages #34 #37

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Conversation

sroertgen
Copy link
Contributor

@sroertgen sroertgen commented Mar 20, 2024

I also changed the repo name of skohub-docker-vocabs to skohub-pages (https://github.com/skohub-io/skohub-pages).

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start the post by describing the workflow with some screenshots and should also add an outlook on making this less dependant on GitHub infrastructure. I have started writing this but haven't finished.

@sroertgen sroertgen requested a review from acka47 March 20, 2024 13:15
@sroertgen
Copy link
Contributor Author

I added some screenshots and adjusted a little bit.

@acka47
Copy link
Member

acka47 commented Mar 20, 2024

I have made some more edits. I suggest to read this again tomorrow, fix the last errors and then publish.

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy with this now. Except for the red in the screenshots maybe, where the SkoHub pink (R230 G0 B125 #e6007d) would look better. If you like, you can adjust it, @sroertgen , but I am also fine with it as is.

@sroertgen sroertgen merged commit 28b9807 into main Mar 21, 2024
@sroertgen sroertgen deleted the 34-skohub-pages branch March 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants