Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the GitHub Pages domain in your vocabulary and make it resolve to your vocabulary #21

Closed
sroertgen opened this issue Mar 14, 2024 · 4 comments · Fixed by #22
Closed
Assignees

Comments

@sroertgen
Copy link
Contributor

It should be possible to actually have working and resolving links when publishing a vocabulary via the GitHub Pages approach

Related skohub-io/skohub-vocabs#26

@sroertgen sroertgen self-assigned this Mar 14, 2024
@sroertgen sroertgen added this to SkoHub Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Backlog in SkoHub Mar 14, 2024
@sroertgen sroertgen moved this from Backlog to Working in SkoHub Mar 14, 2024
sroertgen added a commit that referenced this issue Mar 14, 2024
@sroertgen sroertgen linked a pull request Mar 14, 2024 that will close this issue
sroertgen added a commit that referenced this issue Mar 18, 2024
* Use GitHub Pages domain for resolvable vocabulary links #21

* Add config volume binding #21
@github-project-automation github-project-automation bot moved this from Working to Done in SkoHub Mar 18, 2024
@sroertgen sroertgen moved this from Done to Review in SkoHub Mar 18, 2024
@sroertgen sroertgen reopened this Mar 18, 2024
@sroertgen
Copy link
Contributor Author

@acka47 you can test this now.

The setup is described in the README 8https://github.com/skohub-io/skohub-docker-vocabs?tab=readme-ov-file#custom-domain)

@acka47
Copy link
Member

acka47 commented Mar 18, 2024

+1 This works great, see https://acka47.github.io/skohub-pages/

Some example URIs:

However, I have noticed a general problem that probably not only occurs with SkoHub pages:
We run into problems, when the scheme URI is like https://example.org and we have a concept URI that is https://example.org/index.

In the concrete example these are:

As you can see, the Concept HTML will not be shown but only the scheme HTML. This does not occur for HCRT as we have a specific /scheme URI fpr the concept scheme. I am not sure whether we should do something about it.

@sroertgen
Copy link
Contributor Author

Maybe we should just add a constraint/hint for SkoHub Vocabs that .../index is not a recommended URI

@acka47
Copy link
Member

acka47 commented Mar 22, 2024

Done with #22, announced in https://blog.skohub.io/2024-03-21-skohub-pages/. Closing.

@acka47 acka47 closed this as completed Mar 22, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in SkoHub Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants