Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic configuration of UI and indexing via config file #185

Closed
acka47 opened this issue Apr 26, 2022 · 4 comments · Fixed by #252
Closed

Enable basic configuration of UI and indexing via config file #185

acka47 opened this issue Apr 26, 2022 · 4 comments · Fixed by #252
Assignees

Comments

@acka47
Copy link
Member

acka47 commented Apr 26, 2022

Possible things to be configured:

Questions:

  • Should the config be made per repo or per vocab?
  • What should the file look like? YAML?
@sroertgen
Copy link
Contributor

Questions:

Should the config be mad per repo or per vocab?

Since a skohub-vocabs instance might host multiple vocabs I guess it makes sense to define this per vocab or give something like a default config if nothing is specified for a specific vocab. This might make implementation a little bit more difficult, but seems sensible.

What should the file look like? YAML?

I would actually favour TOML (https://toml.io/en/) over YAML, because it is easier to write and read for humans (easy for machines as well).

@sroertgen
Copy link
Contributor

sroertgen commented Jan 30, 2023

  • UI should also be configurable

@sroertgen
Copy link
Contributor

sroertgen commented Feb 2, 2023

So to summarize the following options should be configurable:

tokenizer: see options https://github.com/nextapps-de/flexsearch/tree/0.6.32#tokenizer
ui:

  • colors
  • logo

And I think I will use yaml though I thought about using toml.

@acka47 Do you want the fonts to be configurable as well or are colors and logo sufficent?

@acka47
Copy link
Member Author

acka47 commented Feb 2, 2023

Do you want the fonts to be configurable as well or are colors and logo sufficent?

Why not? As far as I can see, the only instance that customized the design (for test purposes) also adjusted the fonts: http://zpidvokabulare.surge.sh/index.de.html

@sroertgen sroertgen mentioned this issue Feb 3, 2023
@acka47 acka47 changed the title Enable basic configuration via config file Enable basic configuration of UI and indexing via config file Feb 6, 2023
@sroertgen sroertgen linked a pull request Feb 7, 2023 that will close this issue
@sroertgen sroertgen moved this to Review in SkoHub Feb 7, 2023
@sroertgen sroertgen added this to SkoHub Feb 7, 2023
@acka47 acka47 moved this from Review to Done in SkoHub Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants