change selftest to allow the bitaxe to boot, even if tests fail

[skot]

Currently if one of the selftest tests fail, the Bitaxe will be stuck in selftest mode forever, essentially bricking the Bitaxe for those who don't know how to flash the nvs.

I think that no matter if tests pass or fail we should set nvs selftest=0 and boot normally after the user presses the BOOT button.

Of course it should be very obvious on the OLED and in the logs that tests have failed, so that both users and factories are aware.

[skot]

Also, once we have this functionality then it makes sense to use factory images (selftest=1) on the webflasher @WantClue

[benjamin-wilson]

selftest=0 should only happen after the user presses the BOOT button, so that it can be power cycled and re-tested.

[skot]

I suppose we could get fancy and require a long press on BOOT to restart (and set selftest=0) if there is a failure?

[skot]

This is addressed in PR #524

[benjamin-wilson]

selftest=0 should only happen after the user presses the BOOT button, so that it can be power cycled and re-tested.

When the self test passes, it should not self test again though, sorry if this was miscommunicated. This issue arose when trying to flash 2.4.2.
@skot

[skot]

selftest=0 should only happen after the user presses the BOOT button, so that it can be power cycled and re-tested.

When the self test passes, it should not self test again though, sorry if this was miscommunicated. This issue arose when trying to flash 2.4.2.

@skot

I thought maybe you'd want to test the boot button as that final test. Fine with me either way.