Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Coalesced clients should not be counted as workers #114

Open
agis opened this issue Jan 31, 2019 · 0 comments
Open

Coalesced clients should not be counted as workers #114

agis opened this issue Jan 31, 2019 · 0 comments
Assignees
Labels
bug Something isn't working server
Milestone

Comments

@agis
Copy link
Contributor

agis commented Jan 31, 2019

Currently, clients waiting on an existing pending job are counted as workers as far as the concurrency/backlog limits are concerned.

This means that clients that do not really consume any resources (they just poll an already scheduled build), may end up filling our internal backlog limits and cause the server to stop accepting new builds until one of the pending ones complete, even though the number of pending builds might be less than the concurrency limit. This in conjunction with not having a global timeout limit for builds (#4), may result in mistry not accepting new builds while it could (and should).

Clients coalesced with a pending build should not be taken into account when checking the concurrency and backlog configuration settings.

@agis agis added bug Something isn't working server labels Jan 31, 2019
@agis agis added this to the 1.0 milestone Jan 31, 2019
@avgerin0s avgerin0s self-assigned this Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working server
Projects
None yet
Development

No branches or pull requests

2 participants