Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] revert workaround in notebooks after 1614 is fixed #1625

Open
fkiraly opened this issue Aug 26, 2024 · 1 comment
Open

[MNT] revert workaround in notebooks after 1614 is fixed #1625

fkiraly opened this issue Aug 26, 2024 · 1 comment
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 26, 2024

In #1615, a workaround for the failure caused by #1614 was introduced in order to ensure that notebooks run.

Once #1614 is fixed, we should revert the workaround - that is, we should replace

mean_losses = SMAPE(reduction="none").loss(predictions.output, predictions.y[0]).mean(1)

by

mean_losses = SMAPE(reduction="none")(predictions.output, predictions.y).mean(1)\n

again.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

2 participants
@fkiraly and others