From 59dc4aa9f260097e4063d02912ab8dcccc4e2438 Mon Sep 17 00:00:00 2001 From: skuill Date: Sat, 27 Jan 2024 19:47:17 +0400 Subject: [PATCH 1/3] #19 Added .NET 8 support --- .github/workflows/cicd.yaml | 5 +++++ .../LyricsScraperNET.TestShared.csproj | 2 +- LyricsScraperNET/LyricsScraperNET.csproj | 2 +- .../LyricsScraperNET.IntegrationTest.csproj | 2 +- .../LyricsScraperNET.UnitTest.csproj | 2 +- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cicd.yaml b/.github/workflows/cicd.yaml index b117256..a989513 100644 --- a/.github/workflows/cicd.yaml +++ b/.github/workflows/cicd.yaml @@ -22,6 +22,9 @@ jobs: - uses: actions/setup-dotnet@v3 with: dotnet-version: "7.0.x" + - uses: actions/setup-dotnet@v3 + with: + dotnet-version: "8.0.x" - name: Set RELEASE_VERSION run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV - name: Restore Packages @@ -60,11 +63,13 @@ jobs: zip -j LyricsScraperNET-net5.0.zip LyricsScraperNET/bin/Release/net5.0/* zip -j LyricsScraperNET-net6.0.zip LyricsScraperNET/bin/Release/net6.0/* zip -j LyricsScraperNET-net7.0.zip LyricsScraperNET/bin/Release/net7.0/* + zip -j LyricsScraperNET-net8.0.zip LyricsScraperNET/bin/Release/net8.0/* gh release upload "$RELEASE_VERSION" \ "LyricsScraperNET-netstandard2.0.zip" \ "LyricsScraperNET-netstandard2.1.zip" \ "LyricsScraperNET-net5.0.zip" \ "LyricsScraperNET-net6.0.zip" \ "LyricsScraperNET-net7.0.zip" \ + "LyricsScraperNET-net8.0.zip" \ env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/LyricsScraperNET.TestShared/LyricsScraperNET.TestShared.csproj b/LyricsScraperNET.TestShared/LyricsScraperNET.TestShared.csproj index 298798d..0e0d053 100644 --- a/LyricsScraperNET.TestShared/LyricsScraperNET.TestShared.csproj +++ b/LyricsScraperNET.TestShared/LyricsScraperNET.TestShared.csproj @@ -1,7 +1,7 @@  - net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0 + net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0 diff --git a/LyricsScraperNET/LyricsScraperNET.csproj b/LyricsScraperNET/LyricsScraperNET.csproj index 4e7706d..55f05d7 100644 --- a/LyricsScraperNET/LyricsScraperNET.csproj +++ b/LyricsScraperNET/LyricsScraperNET.csproj @@ -1,7 +1,7 @@  - net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0 + net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0 9.0 enable LyricsScraperNET diff --git a/Tests/LyricsScraperNET.IntegrationTest/LyricsScraperNET.IntegrationTest.csproj b/Tests/LyricsScraperNET.IntegrationTest/LyricsScraperNET.IntegrationTest.csproj index ce0eff4..8a6e5f5 100644 --- a/Tests/LyricsScraperNET.IntegrationTest/LyricsScraperNET.IntegrationTest.csproj +++ b/Tests/LyricsScraperNET.IntegrationTest/LyricsScraperNET.IntegrationTest.csproj @@ -1,7 +1,7 @@  - net7.0 + net8.0 9.0 false diff --git a/Tests/LyricsScraperNET.UnitTest/LyricsScraperNET.UnitTest.csproj b/Tests/LyricsScraperNET.UnitTest/LyricsScraperNET.UnitTest.csproj index 7c3b142..9f35327 100644 --- a/Tests/LyricsScraperNET.UnitTest/LyricsScraperNET.UnitTest.csproj +++ b/Tests/LyricsScraperNET.UnitTest/LyricsScraperNET.UnitTest.csproj @@ -1,7 +1,7 @@  - net7.0;net6.0;net5.0;netcoreapp3.1 + net8.0;net7.0;net6.0;net5.0;netcoreapp3.1 9.0 false From 6739ab8511c1f7affc593987b67104baf1c67cca Mon Sep 17 00:00:00 2001 From: skuill Date: Sat, 27 Jan 2024 19:54:09 +0400 Subject: [PATCH 2/3] #19 Fixed Client framework version --- LyricsScraperNET.Client/LyricsScraperNET.Client.csproj | 4 ++-- LyricsScraperNET.Client/Program.cs | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/LyricsScraperNET.Client/LyricsScraperNET.Client.csproj b/LyricsScraperNET.Client/LyricsScraperNET.Client.csproj index 97bb9af..823c193 100644 --- a/LyricsScraperNET.Client/LyricsScraperNET.Client.csproj +++ b/LyricsScraperNET.Client/LyricsScraperNET.Client.csproj @@ -1,8 +1,8 @@ - + Exe - net7.0;net6.0;net5.0;netcoreapp3.1 + net8.0;net7.0;net6.0;net5.0;netcoreapp3.1 enable diff --git a/LyricsScraperNET.Client/Program.cs b/LyricsScraperNET.Client/Program.cs index cc64b01..fb277a8 100644 --- a/LyricsScraperNET.Client/Program.cs +++ b/LyricsScraperNET.Client/Program.cs @@ -66,6 +66,9 @@ static async Task Main() Console.WriteLine($"\r\nThis lyric was found by [{result.ExternalProviderType}]\r\n"); Console.ResetColor(); + Console.ForegroundColor = ConsoleColor.DarkGray; + Console.WriteLine("Press any key to exit.."); + Console.ResetColor(); Console.ReadLine(); } From c17b8171b69fe1b9bb1598fb18edf38076034156 Mon Sep 17 00:00:00 2001 From: skuill Date: Sat, 27 Jan 2024 19:57:37 +0400 Subject: [PATCH 3/3] #19 Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d0706a9..8b80da7 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ LyricsScraperNET is a library for .NET that provides an API to search for lyrics ## Features -* ✅ Supports multiple frameworks `.NET Standard 2.X`, `.NET 5`, `.NET 6`, `.NET 7` +* ✅ Supports multiple frameworks `.NET Standard 2.X`, `.NET 5`, `.NET 6`, `.NET 7`, `.NET 8` * ✅ Logging supported. * ✅ Modular structure, for easy testing. * ✅ Multiple ways how to configure.