Increase Cmake minimum version to allow using CMAKE_MSVC_RUNTIME_LIBRARY flag #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolarGoose
changed the title
skvadrik
reviewed
Nov 23, 2024
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.12) | |||
| cmake_minimum_required(VERSION 3.15) | |||
There was a problem hiding this comment.
How do you use CMAKE_MSVC_RUNTIME_LIBRARY? I'm not against increasing, but it's strange to increase it for something that is not used anywhere in the build files.
There was a problem hiding this comment.
It will be needed for this issue: Pre-built release binaries? #379
Currently it is used in my repo that produces a Windows binary: re2c-for-Windows/build.ps1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cmake 3.15 introduces CMAKE_MSVC_RUNTIME_LIBRARY
https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html
This flag is very useful to build a static binary on Windows by using
CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded