Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeleted succeeded workflows succeed all future operations #105

Closed
jmendesky opened this issue Mar 23, 2022 · 0 comments · Fixed by #106
Closed

Undeleted succeeded workflows succeed all future operations #105

jmendesky opened this issue Mar 23, 2022 · 0 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@jmendesky
Copy link
Collaborator

jmendesky commented Mar 23, 2022

The operator's logic for determining whether an operation has succeeded is as follows:

If there is a pending workflow for the resource, then the operation is pending
or else, if there is a succeeded workflow for the resource, then the operation has succeeded
or else, if there is a failed workflow for the resource, then the operation has failed
or else the operation has failed.

This relies on the operator always deleting workflows once processed. In debug mode, however, these workflows are not deleted. In the case that the latest workflow has failed but previous workflows have succeeded, the operator will falsely mark the operation as succeeded.

This behaviour should be changed by marking all processed workflows so that they are filtered out for future operations.

@jmendesky jmendesky added the bug Something isn't working label Mar 25, 2022
@jmendesky jmendesky changed the title Suceeded workflows succeed all future operations in debug mode Undeleted succeeded workflows succeed all future operations in debug mode Apr 4, 2022
@jmendesky jmendesky changed the title Undeleted succeeded workflows succeed all future operations in debug mode Undeleted succeeded workflows succeed all future operations Apr 4, 2022
@jmendesky jmendesky added this to the 0.0.3 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant