-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmsg daemon completed #23
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Some comments from my side that we should address.
|
||
### Running in Docker | ||
|
||
1. `docker build -t dmsgd . && docker run -d -v /$PWD/docker_container:/dmsgd-data dmsgd --port=80 --disc="http://dmsg.discovery.skywire.skycoin.com" --sk=***` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring the container with command flag/arguments gets a bit annoying. It may be preferable to mount a config similar to skycoin/skywire#794
I also can build the docker container and it seems to run but does not return any logs. Not sure if that is intended or if that indicates the container not working. Running docker ps
seems to indicate we are not actually exposing any port of the container.
Most people also need some instruction they can copy paste, so I would suggest picking a port other than :80 as it is commonly used by other applications already.
|
||
## dmsg daemon | ||
|
||
This daemon will create `.dmsg-uuid` file, which contains your unique UUID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it was part of the requirements you got, but putting logs and config/ID values in the same file may be less than optimal. Unless this was requested specifically.
|
||
## dmsg daemon | ||
|
||
This daemon will create `.dmsg-uuid` file, which contains your unique UUID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help if you could summarise the purpose of this utility in 2-3 sentences as well.
No description provided.