Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on module init is not printed #1161

Closed
ersonp opened this issue Apr 20, 2022 · 0 comments
Closed

Error on module init is not printed #1161

ersonp opened this issue Apr 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ersonp
Copy link
Contributor

ersonp commented Apr 20, 2022

Describe the bug
The error returned during the initialization of a module is not printed as well as the logs print that the module is successfully initialized. But if other modules are dependent on the errored module then they will forever wait for that module. And because of no error logs it becomes hard to find the issue.

Environment information:

  • OS: e.g. Linux
  • Platform: Linux 5.13.0-39-generic x86_64

Steps to Reproduce
Steps to reproduce the behavior:

  1. Add this log v.log.Error(err) before this line
  2. Build make build
  3. Make two configs with ./skywire-cli config gen -irt
  4. Run hypervisor A sudo ./skywire-visor -c skywire-config.json
  5. On new terminal Run hypervisor B sudo ./skywire-visor -c skywire-config2.json
  6. See the error

Actual behavior
Hypervisor B

[2022-04-20T20:35:34+05:30] ERROR [visor]: listen tcp 127.0.0.1:3435: bind: address already in use
[2022-04-20T20:35:34+05:30] INFO [dmsg_pty]: Initialized in 227.306µs (409.348µs with dependencies)
[2022-04-20T20:35:34+05:30] INFO [cli]: Initialized in 543.949µs (544.22µs with dependencies)

In the logs in hypervisor B where the error listen tcp 127.0.0.1:3435: bind: address already in use is returned by the module but without our log there is no indication of the error. The logs show that the cli module has initialized without any issue but this causes the visor module to not initialize as it is still waiting for the cli module to initialize without any error.

@ersonp ersonp added the bug Something isn't working label Apr 20, 2022
@ersonp ersonp closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant