You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are two targets that I consider broken in the Makefile right now:
Make clean does not use -r flag when removing the build directory and consequently fails. It also fails to remove the ./local directory which we previously used to include. Reasonably so. Unless something about the files contained in local changed, they should also be removed.
We have two make build targets while there should be only one. The skywire-cli does not work with defaults of makefile build if we invoke skywire-cli vpn list
Is a trivial fix.
Requires to update the Makefile and skywire-cli to deal properly with new build paths for apps and other binaries.
Steps to Reproduce
Can be reproduced by running make clean after make build && make install
Is a little more subtle. Setting up a visor with make build && make install, skywire-cli config gen and then running with ./build/skywire-visor -c skywire-config.json, followed by skywire-cli vpn list will lead to an error because the config has not been generated with the correct apps paths.
The text was updated successfully, but these errors were encountered:
Describe the bug
There are two targets that I consider broken in the Makefile right now:
Make clean
does not use-r
flag when removing the build directory and consequently fails. It also fails to remove the./local
directory which we previously used to include. Reasonably so. Unless something about the files contained in local changed, they should also be removed.We have two
make build
targets while there should be only one. Theskywire-cli
does not work with defaults of makefile build if we invokeskywire-cli vpn list
Is a trivial fix.
Requires to update the Makefile and
skywire-cli
to deal properly with new build paths for apps and other binaries.Steps to Reproduce
make clean
aftermake build && make install
make build && make install
,skywire-cli config gen
and then running with./build/skywire-visor -c skywire-config.json
, followed byskywire-cli vpn list
will lead to an error because the config has not been generated with the correct apps paths.The text was updated successfully, but these errors were encountered: