Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple broken makefile targets #1547

Closed
jdknives opened this issue May 9, 2023 · 0 comments · Fixed by #1600
Closed

Multiple broken makefile targets #1547

jdknives opened this issue May 9, 2023 · 0 comments · Fixed by #1600
Labels
bug Something isn't working
Milestone

Comments

@jdknives
Copy link
Member

jdknives commented May 9, 2023

Describe the bug
There are two targets that I consider broken in the Makefile right now:

  1. Make clean does not use -r flag when removing the build directory and consequently fails. It also fails to remove the ./local directory which we previously used to include. Reasonably so. Unless something about the files contained in local changed, they should also be removed.

  2. We have two make build targets while there should be only one. The skywire-cli does not work with defaults of makefile build if we invoke skywire-cli vpn list

  3. Is a trivial fix.

  4. Requires to update the Makefile and skywire-cli to deal properly with new build paths for apps and other binaries.

Steps to Reproduce

  1. Can be reproduced by running make clean after make build && make install
  2. Is a little more subtle. Setting up a visor with make build && make install, skywire-cli config gen and then running with ./build/skywire-visor -c skywire-config.json, followed by skywire-cli vpn list will lead to an error because the config has not been generated with the correct apps paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant