Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement versioned visor config. #362

Closed
evanlinjin opened this issue May 15, 2020 · 0 comments · Fixed by #364
Closed

Properly implement versioned visor config. #362

evanlinjin opened this issue May 15, 2020 · 0 comments · Fixed by #364
Assignees
@evanlinjin
Labels
enhancement New feature or request

Comments

@evanlinjin
Copy link
Contributor

@nkryuchkov I'm thinking of moving config into a separate module, maybe /pkg/visor/visorconfig and having versioned structs. E.g. visorconfig.V1 or something.

Proposed features:

  • Struct per config version.
  • Common interface for all config versions.
  • Ability to upgrade a config file.
  • Ability to read in an older config version.

Originally posted by @evanlinjin in #360
@evanlinjin evanlinjin self-assigned this May 16, 2020
@evanlinjin evanlinjin added the enhancement New feature or request label May 16, 2020
@evanlinjin evanlinjin mentioned this issue May 17, 2020
Merged
7 tasks
@evanlinjin evanlinjin linked a pull request May 18, 2020 that will close this issue
Versioned visor configs. #364
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Versioned visor configs. skycoin/skywire
2 participants
@evanlinjin @jdknives