Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maps instead of slices where lookups often happen #67

Closed
evanlinjin opened this issue Nov 12, 2019 · 0 comments · Fixed by #70
Closed

Use maps instead of slices where lookups often happen #67

evanlinjin opened this issue Nov 12, 2019 · 0 comments · Fixed by #70
Assignees
@nkryuchkov
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@evanlinjin
Copy link
Contributor

evanlinjin commented Nov 12, 2019 •
edited by nkryuchkov
Loading

  1. https://github.com/SkycoinProject/skywire-mainnet/blob/master/pkg/visor/visor.go#L106

Not a part of your work, but what do you think of changing the type of appsConf from slice to hashmap? The most often thing we do is a lookup, which would be faster in that case.

Originally posted by @nkryuchkov in #62
@nkryuchkov nkryuchkov added good first issue Good for newcomers enhancement New feature or request labels Nov 12, 2019
@nkryuchkov nkryuchkov changed the title Improve app configuration management. Use maps instead of slices where lookups often happen Nov 12, 2019
@pikomonde pikomonde mentioned this issue Nov 14, 2019
Merged
@nkryuchkov nkryuchkov self-assigned this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkryuchkov nkryuchkov

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change from slice to map pikomonde/skywire-mainnet
2 participants
@evanlinjin @nkryuchkov