Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed frontend files with go embed #703

Closed
jdknives opened this issue Feb 28, 2021 · 1 comment
Closed

Embed frontend files with go embed #703

jdknives opened this issue Feb 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jdknives
Copy link
Member

Feature description

It seems like Go released a built in way to embed static files into a binary. We are currently using a 3rd party tool called rakyll/statik for doing that. Using the Go built in tool should be preferable as we can deprecate the 3rd party tool and maybe can remove the need to have a separate build target that rebuilds the frontend for the visor.

https://blog.carlmjohnson.net/post/2021/how-to-use-go-embed/
@jdknives jdknives added the enhancement New feature or request label Feb 28, 2021
@jdknives jdknives changed the title Embed frontend files with embed Embed frontend files with go embed Feb 28, 2021
@Darkren Darkren mentioned this issue Mar 1, 2021
Merged
@jdknives
Copy link
Member Author

Fixed by #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdknives