Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement visor restart from hypervisor #80

Merged
merged 13 commits into from
Dec 27, 2019
Merged

Implement visor restart from hypervisor #80

merged 13 commits into from
Dec 27, 2019

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Dec 17, 2019 •
edited
Loading

Fixes #64

Changes:

  • Implement visor restart from hypervisor. It can be used via /nodes/{pk}/restart endpoint.

How to test this PR:

  1. Unit tests
  • Run added unit tests for ./pkg/restart/
  1. Integration tests
  • Run the generic integration environment
  • Run ps aux | grep visor
  • Check visors' PIDs
  • In shell pane run curl http://localhost:8080/api/nodes/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/restart
  • In NodeA pane make sure visor was restarted
  • Run ps aux | grep visor
  • Make sure that NodeA's PID differs

evanlinjin
evanlinjin reviewed Dec 24, 2019
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

pkg/restart/restart.go Outdated Show resolved Hide resolved
pkg/visor/rpc.go Show resolved Hide resolved
@nkryuchkov nkryuchkov force-pushed the feature/restart-visor branch from 37a39fb to b1caac5 Compare December 24, 2019 12:06
@nkryuchkov nkryuchkov marked this pull request as ready for review December 26, 2019 18:36
@nkryuchkov nkryuchkov added enhancement New feature or request milestone2 labels Dec 26, 2019
Darkren
Darkren approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Darkren Darkren merged commit 137c9c3 into skycoin:milestone2 Dec 27, 2019
@nkryuchkov nkryuchkov deleted the feature/restart-visor branch March 13, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkryuchkov @Darkren @evanlinjin