Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet visibility bug when dismissing #30

Open
nilufer32 opened this issue May 13, 2024 · 14 comments
Open

Bottom Sheet visibility bug when dismissing #30

nilufer32 opened this issue May 13, 2024 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@nilufer32
Copy link

Please complete the following information:

  • Library Version [e.g. v1.0.0] : latest commit 1c0e68f
  • Affected Device(s) [e.g. Samsung Galaxy s10 with Android 9.0]
    OppoCPH1803 , Samsung A510F, Iphone
    Describe the Bug:

Add a clear description about the problem.
When dismissing the sheet using a drag gesture, the bottom sheet disappears for a split second then just before completely hiding it reappears again and hides fully. Also, in this state of the sheet "disappearing" if I drag the sheet up instead of down it reappears again.
Expected Behavior:

A clear description of what you expected to happen.

The sheet should always be visible on screen as long as I'm dragging it and it should only fully disappear when I fully drag it downwards.

@H4kt
Copy link

H4kt commented May 30, 2024

+1

@skydoves
Copy link
Owner

skydoves commented Jun 6, 2024

Hey guys, would you provide a video for this behavior? Thank you!

@Kev1000000
Copy link

This happens when you swipe to dismiss (while still holding your finger down) for me at least.

@sevbanBayir
Copy link

sevbanBayir commented Aug 2, 2024

+1

This exactly happens when you try to swipe to dismiss from anywhere else than DragHandle

@skydoves
Copy link
Owner

skydoves commented Aug 2, 2024

Hey everyone, thanks for checking out this issue. I just confirmed that it occurs when using LazyColumn or any scrollable component inside the flexible bottom sheet. Fixing this bug is a high priority for me.

@skydoves
Copy link
Owner

skydoves commented Aug 4, 2024

Hey guys, 0.1.4 has been released, and I hope this new release resolves this issue.

@Kev1000000
Copy link

Hey there, this unfortunately didn't solve the issue for me. On some scrolls it is fixed, but it still happens about 80% of the time =(

@skydoves
Copy link
Owner

skydoves commented Aug 5, 2024

Hey @Kev1000000, do you have any screenshots? and I'm wondering if it happens on dragging or snapping (flinging) behavior?

@Kev1000000
Copy link

Kev1000000 commented Aug 5, 2024

Screen_recording_20240805_002126.webm

Note, I am holding during this bottom sheet drag. It is disappearing while dragging down. As I drag up, it returns.

@sevbanBayir
Copy link

Same here, issue still persists with 0.1.4 . Im using a Column with a verticalScroll() modifier in FlexibleBottomSheet.

@Maandraj
Copy link

Maandraj commented Aug 7, 2024

Same here, issue still persists with 0.1.4 . Im using a Column wit

I also have a problem that has not been solved.

@Maandraj
Copy link

Maandraj commented Aug 7, 2024

@sevbanBayir @skydoves
I found a solution, although it looks crutchy.

var scrollEnabled by remember { mutableStateOf(false) }
scrollEnabled = when (it) {
                FlexibleSheetValue.Hidden -> {
                    false
                }
                FlexibleSheetValue.FullyExpanded -> {
                    true
                }
                FlexibleSheetValue.IntermediatelyExpanded -> {
                    true
                }
                FlexibleSheetValue.SlightlyExpanded -> {
                    false
                }
            }
Column(modifier= Modifier.verticalScroll(rememberScrollState(), enabled = scrollEnabled))

@TemMax
Copy link

TemMax commented Aug 19, 2024

I've noticed that it happens only for non-modal sheets like rememberFlexibleBottomSheetState(isModal = false)

@TemMax
Copy link

TemMax commented Aug 19, 2024

UPD: nope, it happens for modal sheets as well. But when the sheet is modal, there is no padding glitch, only disappearing happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants