Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The arrow toggle on empty list #16

Closed
shivam0x opened this issue May 2, 2020 · 2 comments
Closed

The arrow toggle on empty list #16

shivam0x opened this issue May 2, 2020 · 2 comments
Assignees
Labels
released released already the last version

Comments

@shivam0x
Copy link

shivam0x commented May 2, 2020

Please complete the following information:

  • Library Version [e.g. v1.0.7]
  • Affected Device(s) [Any device]

Describe the Bug:

I've setup the spinner and the data has not been inflated in the spinner till now. So basically its an empty spinner till now. When I click on the spinner it toggles as per the implementation of setOnClickListener() in PowerSpinnerView. I tried to override setOnClickListener() but it did not work. So can you add a check in toggle() that it only toggles if list size > 0.

Something like this : if (adapter.getItems().isNotEmpty()) showOrDismiss()
Need to add a getItems() in adapter classes which will return the list else can add a getSize() too which will return size only.

Expected Behavior:

It should not toggle the list, arrow should not animate.

@skydoves skydoves self-assigned this May 2, 2020
@skydoves skydoves added the Release Next This feature will be released on next version label May 2, 2020
@shivam0x
Copy link
Author

shivam0x commented May 3, 2020

@skydoves Shall I raise a PR for the same?

@skydoves skydoves added released released already the last version and removed Release Next This feature will be released on next version labels May 10, 2020
@skydoves
Copy link
Owner

It is released on the new version 1.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released released already the last version
Projects
None yet
Development

No branches or pull requests

2 participants