Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressViewOrientation.VERTICAL #10

Closed
allison-lekwa opened this issue Feb 4, 2020 · 9 comments
Closed

ProgressViewOrientation.VERTICAL #10

allison-lekwa opened this issue Feb 4, 2020 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@allison-lekwa
Copy link

The progress view orientation VERTICAL not working

@skydoves
Copy link
Owner

skydoves commented Feb 5, 2020

@allison-lekwa
Hi, did you set a specific value to the width and height like below?

<com.skydoves.progressview.ProgressView
  android:layout_width="35dp"
  android:layout_height="300dp"
  app:progressView_orientation="vertical"
  
  ...

@allison-lekwa
Copy link
Author

@skydoves
Hello, yes I did. The horizontal orientation worked perfectly, but the vertical does not show any animation

@skydoves
Copy link
Owner

skydoves commented Feb 5, 2020

@allison-lekwa
Hmm.. In the demo activity, it works well.
It seems to be affected by some other situation.

@allison-lekwa
Copy link
Author

Even in the demo, the vertical orientation did not work.....

@skydoves
Copy link
Owner

skydoves commented Feb 5, 2020

The vertical attribute does below internally.

progressView.rotation = 180f
progressView.highlightView.rotation = 180f

Could you make the rotation manually 180f with the horizontal option?

@allison-lekwa
Copy link
Author

I already did, and this are my observation

progressView.highlightView.rotation = 180f
Does not change anything... Also I do not know whether it has to do with the canvas.path

@siddesh13
Copy link

This vertical progress view does not work on android 7 Nougat, but android 8 onwards it works
do you have any solution how can we show it on android 7

@skydoves skydoves self-assigned this Aug 13, 2020
@skydoves
Copy link
Owner

Hi, @siddesh13.
I just tested using API 17~21 devices but it is hard to represent the issue.
Could you build using this demo project and let me the specific device information?

@skydoves skydoves added the bug Something isn't working label Sep 5, 2020
@skydoves
Copy link
Owner

Fixed in the new version 1.1.0.
Thank you for the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants