fix: check if synthetic class not yet processed but must be removed (#…

…450)
skylot · Mar 2, 2019 · d069928 · d069928
1 parent dd13edf
commit d069928
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/jadx-core/src/main/java/jadx/core/dex/visitors/ClassModifier.java b/jadx-core/src/main/java/jadx/core/dex/visitors/ClassModifier.java
@@ -47,10 +47,7 @@ public boolean visit(ClassNode cls) throws JadxException {
 		for (ClassNode inner : cls.getInnerClasses()) {
 			visit(inner);
 		}
-		if (cls.getAccessFlags().isSynthetic()
-				&& cls.getFields().isEmpty()
-				&& cls.getMethods().isEmpty()
-				&& cls.getInnerClasses().isEmpty()) {
+		if (isEmptySyntheticClass(cls)) {
 			cls.add(AFlag.DONT_GENERATE);
 			return false;
 		}
@@ -62,6 +59,13 @@ public boolean visit(ClassNode cls) throws JadxException {
 		return false;
 	}
 
+	private static boolean isEmptySyntheticClass(ClassNode cls) {
+		return cls.getAccessFlags().isSynthetic()
+				&& cls.getFields().isEmpty()
+				&& cls.getMethods().isEmpty()
+				&& cls.getInnerClasses().isEmpty();
+	}
+
 	private void markAnonymousClass(ClassNode cls) {
 		if (cls.isAnonymous()) {
 			cls.add(AFlag.ANONYMOUS_CLASS);
@@ -173,7 +177,7 @@ private static boolean isRemovedClassInArgs(ClassNode cls, List<RegisterArg> mth
 					return true;
 				}
 			} else {
-				if (argCls.contains(AFlag.DONT_GENERATE)) {
+				if (argCls.contains(AFlag.DONT_GENERATE) || isEmptySyntheticClass(argCls)) {
 					return true;
 				}
 			}