Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates code of missing R class #353

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Generates code of missing R class #353

merged 1 commit into from
Sep 8, 2018

Conversation

bagipro
Copy link
Collaborator

@bagipro bagipro commented Sep 2, 2018

Hi, there are a few things:

  • generated code isn't getting saved by some reason
  • I believe it's not an issue that I don't create inner classes?
  • I mentioned arrays in original R classes like public static final int[] ZoomOval = new int[0];, I will find out why they exist, and add it in a new commit in future

This PR is for #308

@ghost
Copy link

ghost commented Sep 2, 2018

There were the following issues with this Pull Request

  • Commit: f2ea182
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@skylot skylot merged commit 5de4d07 into master Sep 8, 2018
@skylot
Copy link
Owner

skylot commented Sep 8, 2018

@sergey-wowwow I merged your commit and made some changes to fix tests and generation of R class.
Short description of current R class processing:

  • if R class not found in app package (read from manifest) it will be generated
  • all resources fields will be added to that class
  • in result, all resources ids will be reference to that R class
  • if original R class is located in another package it will not be used (actually there are can be int array fields which not redirected for now - need to fix)
  • all const fields replacement (including resources) can be disabled using --no-replace-consts option

I hope it will fix your issues with resource ids replacements

@skylot skylot deleted the r_class_gen branch September 8, 2018 15:05
@skylot
Copy link
Owner

skylot commented Feb 12, 2019

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants