Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not allowed access modifiers for methods #439

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix not allowed access modifiers for methods #439

merged 1 commit into from
Feb 11, 2019

Conversation

skylot
Copy link
Owner

@skylot skylot commented Feb 7, 2019

This PR fix visibility access modifies for methods (see discussions in #370 and #387):
Short description:

  • all virtual methods become public
  • direct methods become private (instead constructors and static methods for now)
  • such modifications perform by default and can be disabled by the option in preferences (--respect-bytecode-access-modifiers in jadx-cli)
  • if changed to method added comment (Access modifiers changed, original: private)

If anyone has any suggestions, please leave a comment.

@skylot skylot merged commit 8c7140d into master Feb 11, 2019
@skylot skylot deleted the issue-387 branch February 11, 2019 12:04
@skylot
Copy link
Owner Author

skylot commented Feb 12, 2019

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant